Skip to content

Disable token exchange rule in pre-issue access token action v1 #9533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Lashen1227 wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Disable token exchange rule in pre-issue access token action v1 #9533

Lashen1227 wants to merge 1 commit into from
+12 −0

Conversation

@Lashen1227
Copy link
Member

@Lashen1227 Lashen1227 commented Dec 30, 2025

This pull request updates the pre-issue access token action configuration form to support version-specific rule restrictions and improves how disallowed rules are handled for different action types.

Key changes:

  • Extends the ActionsConstants.__TEMPORARY__DISALLOWED_RULES object to include version-specific disallowed rules for the PRE_ISSUE_ACCESS_TOKEN_URL_PATH action type.
  • Specifically, the "urn:ietf:params:oauth:grant-type:token-exchange" rule is now disallowed for version v1.

V1:
pre-issue access token action v1

V2:
pre-issue access token action v2

Related PRs

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

Developer Checklist (Mandatory)

  • Complete the Developer Checklist in the related product-is issue to track any behavioral change or migration impact.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 30, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.88%. Comparing base (9ece403) to head (20b71a5).
⚠️ Report is 101 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #9533   +/-   ##
=======================================
  Coverage   55.88%   55.88%           
=======================================
  Files          42       42           
  Lines        1020     1020           
  Branches      254      254           
=======================================
  Hits          570      570           
  Misses        416      416           
  Partials       34       34
Flag Coverage Δ
@wso2is/core 55.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Lashen1227